[Bug 702988] gdkpixbufoverlay: crashes if any property changes during playback when location property is not set

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702988
  GStreamer | gst-plugins-good | 1.0.7

--- Comment #2 from Kishore <kishore.arepalli at gmail.com> 2013-07-01 10:41:55 UTC ---
(In reply to comment #1)
> Review of attachment 247653 [details]:
> 
> ::: ext/gdk_pixbuf/gstgdkpixbufoverlay.c
> @@ +223,3 @@
>        overlay->location = g_value_dup_string (value);
> +      if (!gst_gdk_pixbuf_overlay_load_image (overlay, &err)) {
> +        GST_ERROR_OBJECT (overlay, ("Could not load overlay image. %s",
> 
> This needs some locking, if we allow changing these things from properties you
> need to protect all accesses everywhere to it with a mutex.

Complete set_property method is already locked.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.