[Bug 703405] playbin: stream-combiners can't be bins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703405
  GStreamer | gst-plugins-base | git

--- Comment #3 from Brendan Long <self at brendanlong.com> 2013-07-01 18:54:40 UTC ---
Created an attachment (id=248179)
 View: https://bugzilla.gnome.org/attachment.cgi?id=248179
 Review: https://bugzilla.gnome.org/review?bug=703405&attachment=248179

Fail gracefully if custom combiner doesn't return a request pad

This patch makes this case error out instead of hanging:

$ gst-launch-1.0 playbin
uri=http://ftp.nluug.nl/ftp/graphics/blender/apricot/trailer/Sintel_Trailer1.480p.DivX_Plus_HD.mkv
text-stream-combiner="funnel"
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Redistribute latency...
0:00:00.752194504 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.752367212 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.752535232 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.752686087 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.752889619 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.753039442 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.753218202 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
0:00:00.753373756 27788 0x7f48580bd940 ERROR                playbin
gstplaybin2.c:3178:pad_added_cb:<playbin0> failed to get request pad from
combiner 0x1414120
ERROR: from element /GstPlayBin:playbin0: Internal playbin error.
Additional debug info:
gstplaybin2.c(3350): no_more_pads_cb (): /GstPlayBin:playbin0:
Failed to link combiner to sink. Error -1
ERROR: pipeline doesn't want to preroll.
Setting pipeline to NULL ...
Freeing pipeline ...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.