[Bug 703405] playbin: stream-combiners can't be bins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703405
  GStreamer | gst-plugins-base | git

--- Comment #8 from Brendan Long <self at brendanlong.com> 2013-07-01 20:07:05 UTC ---
Created an attachment (id=248182)
 View: https://bugzilla.gnome.org/attachment.cgi?id=248182
 Review: https://bugzilla.gnome.org/review?bug=703405&attachment=248182

(not working) When parsing a bin with a single element, just return the element
instead of creating a bin

So this changes the parser to return the element instead of a bin when parsing
a single-element bin. It causes some warnings though:

    gst-launch-1.0 playbin
uri='https://dl.dropboxusercontent.com/s/x03ogh3epbd6lfq/example.mkv?token_hash=AAGW4CSrXYj9fNjD0CpO465zuXLRY0WEXcUy2lxQ5IOYJg&dl=1'
audio-stream-combiner="adder"

(gst-launch-1.0:28056): GStreamer-CRITICAL **: gst_bin_find_unlinked_pad:
assertion `GST_IS_BIN (bin)' failed
(gst-launch-1.0:28056): GStreamer-CRITICAL **: gst_bin_find_unlinked_pad:
assertion `GST_IS_BIN (bin)' failed

#0  0x00007ffff78e4fdb in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007ffff78e51b2 in g_log () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007ffff7f8ac99 in gst_bin_find_unlinked_pad (bin=0x5ba050,
direction=GST_PAD_SRC) at gstutils.c:2952
#3  0x00007ffff7f8af80 in gst_parse_bin_from_description_full
(bin_description=0x5b0c56 "adder", ghost_unlinked_pads=1, 
    context=0x0, flags=GST_PARSE_FLAG_NONE, err=0x0) at gstutils.c:3064
#4  0x00007ffff7f8ae06 in gst_parse_bin_from_description
(bin_description=0x5b0c56 "adder", ghost_unlinked_pads=1, err=0x0)
    at gstutils.c:3009
#5  0x00007ffff7fa284b in gst_parse_element_set (value=0x5b0c40
"audio-stream-combiner", element=0x5b2970, graph=0x7fffffffbac0)
    at ./grammar.y:457
#6  0x00007ffff7fa490a in priv_gst_parse_yyparse (scanner=0x59b800,
graph=0x7fffffffbac0) at ./grammar.y:688
#7  0x00007ffff7fa8015 in priv_gst_parse_launch (
    str=0x59b8d0 "playbin
uri=https://dl.dropboxusercontent.com/s/x03ogh3epbd6lfq/example.mkv?token_hash=AAGW4CSrXYj9fNjD0CpO465zuXLRY0WEXcUy2lxQ5IOYJg&dl=1
audio-stream-combiner=adder ", error=0x7fffffffbe48, ctx=0x0,
flags=GST_PARSE_FLAG_NONE)
    at ./grammar.y:945
#8  0x00007ffff7f9bb59 in gst_parse_launch_full (
    pipeline_description=0x59b8d0 "playbin
uri=https://dl.dropboxusercontent.com/s/x03ogh3epbd6lfq/example.mkv?token_hash=AAGW4CSrXYj9fNjD0CpO465zuXLRY0WEXcUy2lxQ5IOYJg&dl=1
audio-stream-combiner=adder ", context=0x0, flags=GST_PARSE_FLAG_NONE, 
    error=0x7fffffffbe48) at gstparse.c:324
#9  0x00007ffff7f9ba21 in gst_parse_launchv_full (argv=0x59b8a0, context=0x0,
flags=GST_PARSE_FLAG_NONE, error=0x7fffffffbe48)
    at gstparse.c:262
#10 0x00007ffff7f9b8b3 in gst_parse_launchv (argv=0x59b8a0,
error=0x7fffffffbe48) at gstparse.c:215
#11 0x0000000000405da4 in main (argc=4, argv=0x7fffffffbfe8) at
gst-launch.c:1025

I'll look into it more if I have time.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.