[Bug 703499] videomixer: take the newly introduced segment->offset into account.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703499
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248264|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-03 06:19:50 UTC ---
Review of attachment 248264:
 --> (https://bugzilla.gnome.org/review?bug=703499&attachment=248264)

::: gst/videomixer/videomixer2.c
@@ +710,3 @@
       /* Check if it's inside the segment */
+      if (start_time < segment->start + segment->offset
+          || end_time >= segment->stop + segment->offset) {

Independent of the addition of offset, this is not correct. A buffer can still
be inside the segment if the start time is before the actual start (i.e. if the
end time is after the start), and also if the end time is after the end (i.e.
if the start time is before the end).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.