[Bug 703378] pbutils: recent caps description patch can mistakenly confuse different formats

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703378
  GStreamer | gst-plugins-base | git

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-03 06:23:47 UTC ---
(In reply to comment #5)

> However, the restrictions I get from libgupnp-dlna aren't always "simple". Some
> have more than one structure, usually with the same format but different
> resolutions, etc. Those caps are usually not fixed: they contain some amount of
> leeway in things like bitrate, etc. It depends on the particular profile.

Things like resolution restrictions should be placed into constraints of the
encoding profile though, most probably making these caps fixed again.

> When encodebin can find elements to build a pipeline that can transcode to
> those caps, all is fine.

What is encodebin doing then? Taking the first, highest ranked element that
somehow matches the caps?

> However, since it is possible to provide such a description of the caps in some
> cases where we get non fixed caps (eg, when all structures in the caps describe
> the same format), these patches do this. Maybe they will miss some cases, but
> surely it's better than just asserting. If any case is missed, the assert will
> be here as before.

Maybe encodebin should expand the caps to simple caps and then pass them to the
missing-plugin code instead? That way there would be multiple missing plugin
messages though. Alternatively, maybe allowing non-fixed caps for the missing
plugin messages makes sense?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.