[Bug 703405] playbin: stream-combiners can't be bins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703405
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248247|none                        |reviewed
             status|                            |

--- Comment #21 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-03 09:36:19 UTC ---
Review of attachment 248247:
 --> (https://bugzilla.gnome.org/review?bug=703405&attachment=248247)

::: gst/gstutils.c
@@ +3068,3 @@
+  } else {
+    bin = GST_BIN (gst_bin_new (NULL));
+    if (!gst_bin_add (bin, element)) {

Does this provide exactly the same behaviour as before? I remember that there
is something in this code that would expose all unlinked pads inside the bin as
ghostpads on the bin

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.