[Bug 701404] dashdemux: should not buffer the entire Period

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701404
  GStreamer | gst-plugins-bad | 1.x

--- Comment #14 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-07-03 19:49:08 UTC ---
Review of attachment 246653:
 --> (https://bugzilla.gnome.org/review?bug=701404&attachment=246653)

This patch misses some kind of condition waiting to avoid looping continuously
knowing that there isn't room for buffering

::: ext/dash/gstdashdemux.c
@@ +1533,3 @@
+  buffered_duration = gst_dash_demux_get_buffering_time (demux);
+  while ((GST_TIME_AS_MSECONDS (buffered_duration) < minBufferTime) &&
+      buffered_duration <= demux->max_buffering_time) {

The task is called repeatedly anyway, not sure we want a while here without any
cancel checks.

And why shouldn't it be:

while ((GST_TIME_AS_MSECONDS (buffered_duration) < minBufferTime) ||
buffered_duration <= demux->max_buffering_time) ?

After all this is a "minimum buffering time".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.