[Bug 692933] [API] codecparsers: mpeg2: add new API that takes GstMpegVideoPacket arguments

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jul 4 05:45:22 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=692933
  GStreamer | gst-plugins-bad | unspecified

--- Comment #8 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-07-04 12:45:18 UTC ---
Review of attachment 248373:
 --> (https://bugzilla.gnome.org/review?bug=692933&attachment=248373)

::: gst/videoparsers/gstmpegvideoparse.c
@@ +318,3 @@
     mpvparse->config_flags |= FLAG_MPEG2;
+    if (packet.size > 1) {
+      packet.type = packet.data[packet.offset] >> 4;

Note: I am abusing packet.type here. It should be
GST_MPEG_VIDEO_PACKET_EXTENSION and the sub_type parsed separately, but
packet.type is not used in the codec parser library. But anyway, I will
probably just fix it to the correct way to be on the safe side.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list