[Bug 687182] playbin: autoplugging s/w and h/w accelerated deinterlacers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687182
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248387|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-05 08:04:47 UTC ---
Review of attachment 248387:
 --> (https://bugzilla.gnome.org/review?bug=687182&attachment=248387)

Some name nitpicking... GstVideoPostProcessor maybe? And instead of vpp write
it out?

Shouldn't there be something to enable/disable the different postproc
functions, i.e. enable/disable a denoise filter?

::: gst-libs/gst/video/videopostproc.c
@@ +63,3 @@
+  /* Video post processing operations like deinterlace, colorbalance etc */
+  g_object_interface_install_property (g_class,
+      g_param_spec_flags ("vpp-type",

-typeS. Maybe call it supported-*-types?
Why is this a property but HW acceleration is a vfunc?

::: gst-libs/gst/video/videopostproc.h
@@ +59,3 @@
+  GST_VIDEO_POSTPROC_DENOISE         = (1 << 2),
+  GST_VIDEO_POSTPROC_SCALE        = (1 << 3),
+  GST_VIDEO_POSTPROC_COLORSPACE        = (1 << 4),

This would probably not be just about colorspace conversion but also
subsampling conversion, component order conversion, plane layout conversion,
etc... like what videoconvert does?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.