[Bug 585969] [playbin2] [gapless] Position/Duration information mismatch on track change

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=585969
  GStreamer | gst-plugins-base | 0.10.23

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248409|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-05 08:35:48 UTC ---
Review of attachment 248409:
 --> (https://bugzilla.gnome.org/review?bug=585969&attachment=248409)

Looks good in general

::: gst/playback/gstplaybin2.c
@@ -2624,3 @@
     if (group->stream_changed_pending_lock.p) {
       g_mutex_lock (&group->stream_changed_pending_lock);
-      pending = group->pending || group->stream_changed_pending;

Please remove the old stream_changed_pending or reuse it for your uses instead
of adding a new field. The old stream_changed_pending is not used anywhere
anymore.

@@ +3487,3 @@
   /* now activate the next group. If the app did not set a uri, this will
    * fail and we can do EOS */
+  setup_next_source (playbin, GST_STATE_PLAYING);

Why?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.