[Bug 664274] [API] codecparsers: add gst_mpeg_video_parse_slice() and gst_mpeg_video_parse_sequence_scalable_extension()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664274
  GStreamer | gst-plugins-bad | git

--- Comment #31 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-07-05 13:40:27 UTC ---
Review of attachment 248453:
 --> (https://bugzilla.gnome.org/review?bug=664274&attachment=248453)

::: gst-libs/gst/codecparsers/gstmpegvideoparser.c
@@ +960,3 @@
+  guint height;
+  guint mb_inc;
+  guint8 bits = 0, extra_bits = 0;

Junk bytes don't need to be initialized.

@@ +961,3 @@
+  guint mb_inc;
+  guint8 bits = 0, extra_bits = 0;
+  guint8 vertical_position = 0, vertical_position_extension = 0;

Only vertical_position_extension needs to be zero-initialized, not
vertical_position.

@@ +972,3 @@
+
+  SKIP (&br, 24);
+  vertical_position = gst_bit_reader_get_bits_uint8_unchecked (&br, 8);

I don't think this will work since the offset is relative to the actual slice
header start, without the start_code_prefix.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.