[Bug 700491] [dashdemux] Handle cases where minimumUpdatePeriod sets the period length

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700491
  GStreamer | gst-plugins-bad | git

--- Comment #17 from Greg Rutz <greg at gsr-tek.com> 2013-07-05 18:12:54 UTC ---
Review of attachment 245579:
 --> (https://bugzilla.gnome.org/review?bug=700491&attachment=245579)

I agree with Thiago, that this might not be quite correct.  But I think its
close.  The spec says that this is true only for templates because templates
are the only "open-ended" segment specification.  With segment list and
timeline, the parser can easily calculate the duration of the period by summing
the duration of the segments (since every segment is described explicitly). 
While with segment templates, each segment has a duration, but the total number
of segments may be unknown.  We need a new patch that ensures that Period
duration is properly calculated in all 3 cases (this current patch only
addresses one of them).

::: ext/dash/gstmpdparser.c
@@ +3035,3 @@
+      /* might be a live file, ignore unspecified duration if no updates */
+      if (client->mpd_node->minimumUpdatePeriod != -1) {
+        duration = client->mpd_node->minimumUpdatePeriod;

This calculation of duration is incorrect because it doesn't factor in the
proper units.  minimumUpdatePeriod is in msecs, while duration is a
GstClockTime in nsecs.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.