[Bug 702632] acceptcaps query can be very very slow

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jul 8 05:52:38 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=702632
  GStreamer | gstreamer (core) | git

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-08 12:52:33 UTC ---
The rtpmux one looks like a bug in the rtpmux CAPS query handler... this code
looks completely wrong.

1) The condition in clear_caps() does not make any sense at all, it should
probably be (strcmp (name, "clock-rate") == 0 || (!only_clock_rate && strcmp
(name, "ssrc") == 0))

2) Querying the sinkpad caps, causes a downstream caps query (ok) and an
upstream caps query for every sinkpad (not ok)


It's not clear to me when and where ssrc and clock-rate should be ignored and
where not. However it is necessary to not pass any of these fields as filter
caps to any CAPS query if they should be ignored. The one in
same_clock_rate_fold() looks like a good candidate where no filter caps (or
cleared filter caps) should be passed to the query.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list