[Bug 691419] osxvideosink doesn't close internal window in case of window-id assignment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691419
  GStreamer | gst-plugins-good | 0.10.36

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248709|none                        |reviewed
             status|                            |

--- Comment #14 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-09 12:51:26 UTC ---
Review of attachment 248709:
 --> (https://bugzilla.gnome.org/review?bug=691419&attachment=248709)

::: sys/osxvideo/osxvideosink.m
@@ +644,3 @@
+      osxvideosink->osxwindow->closed = TRUE;
+      [osxvideosink->osxwindow->win close];
+      [osxvideosink->osxwindow->win release];

You do realize that this can be called from any thread? Is this a problem? What
happens if at the same time the sink wants to render something, shouldn't there
be some locking?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.