[Bug 703901] The output audioecho got bad if delay value got changed when playing or paused

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703901
  GStreamer | gst-plugins-good | 1.0.5

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248835|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-11 08:09:34 UTC ---
Review of attachment 248835:
 --> (https://bugzilla.gnome.org/review?bug=703901&attachment=248835)

Please attach this as a "git format-patch" style patch. For this commit the
changes locally (check that git uses your mail address and name) and use "git
format-patch -1"

::: audioecho.c.old
@@ +203,3 @@
         self->delay = delay;
         self->max_delay = MAX (delay, max_delay);
+        if(self->max_delay>max_delay) {

This happens only in READY state and there we don't have a buffer allocated
yet. The code in line 195 is for the case when we're PAUSED/PLAYING already and
have a buffer.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.