[Bug 699077] [videorate] Add a property to modify clip speed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699077
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248849|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-11 10:38:12 UTC ---
Review of attachment 248849:
 --> (https://bugzilla.gnome.org/review?bug=699077&attachment=248849)

::: gst/videorate/gstvideorate.c
@@ +744,3 @@
+      if (GST_CLOCK_TIME_IS_VALID (segment.stop))
+        segment.stop = (gint64) (segment.stop / videorate->rate);
+      segment.time = (gint64) (segment.time / videorate->rate);

I believe you also want to scale segment.applied_rate here

@@ +917,3 @@
+        break;
+      }
+      dst_value = (gint64) (videorate->next_ts / videorate->rate);

This might give weird values if the rate is changed during playback. Changing
the rate should probably keep the current timestamp somewhere else and reset
next_ts to 0. And here then use the timestamp offset + next_ts/rate

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.