[Bug 704007] qtdemux skips disabled tracks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704007
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248929|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-12 08:24:16 UTC ---
Review of attachment 248929:
 --> (https://bugzilla.gnome.org/review?bug=704007&attachment=248929)

::: gst/isomp4/qtdemux.c
@@ +7018,3 @@
+      if (length >= 12) {
+        qtdemux->chapters_track_id =
+            GST_READ_UINT32_BE ((gint8 *) chap->data + 8);

Couldn't there be multiple chapters tracks?

@@ +8387,3 @@

+    if ((stream->subtype == FOURCC_text || stream->subtype == FOURCC_sbtl) &&
+        stream->track_id == qtdemux->chapters_track_id) {

Why are chapters tracks shown as subtitle tracks at all?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.