[Bug 628429] Add support for DivX XSUB subtitles

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=628429
  GStreamer | gst-plugins-bad | unspecified

--- Comment #20 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2013-07-13 02:13:26 UTC ---
(In reply to comment #15)
> (In reply to comment #14)
> > Review of attachment 248965 [details] [details]:
> [...]
> 
> > @@ +256,3 @@
> > +  GstStructure *structure = gst_caps_get_structure (caps, 0);
> > +
> > +  filter = GST_XSUB (gst_pad_get_parent (pad));
> > 
> > You already had the parent in the event function, just pass it through here
> 
> Assrender seems to do the same. I's there a particular
> justification for this change?

Done.

> [...] 
> > ::: gst/xsub/gstxsub.h
> > @@ +75,3 @@
> > +  gboolean show_bg;
> > +
> > +  GQueue *spu_queue;
> > 
> > You can also store the GQueue directly (not as a pointer)

Done.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.