[Bug 704070] video: Add Region Of Interest (roi) meta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704070
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249190|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-15 12:58:26 UTC ---
Review of attachment 249190:
 --> (https://bugzilla.gnome.org/review?bug=704070&attachment=249190)

Almost ready :)

::: gst-libs/gst/video/gstvideometa.c
@@ +532,3 @@
+/* Region of Interest Meta implementation
*******************************************/
+GQuark
+gst_video_region_of_interest_meta_bounding_box_get_quark (void)

I don't think that's what was meant :) Just mention in the documentation of
this GstMeta that it only describes a bounding box for the ROI, and not the
exact shape

@@ +562,3 @@
+{
+  GstVideoRegionOfInterestMeta *dmeta, *smeta;
+

Need to copy the parent_id and id here too

@@ +647,3 @@
+GstVideoRegionOfInterestMeta *
+gst_buffer_add_video_region_of_interest_meta_by_name (GstBuffer * buffer,
+                              gchar * roi_type, 

const gchar *

@@ +657,3 @@
+  meta = (GstVideoRegionOfInterestMeta *) gst_buffer_add_meta (buffer,
+      GST_VIDEO_REGION_OF_INTEREST_META_INFO, NULL);
+  meta->roi_type = g_quark_from_string  (roi_type);

Just let this function call the other one that takes the GQuark

@@ +682,3 @@
+  meta->y = y;
+  meta->w = w;
+  meta->h = h;

Initialize the parent_id and id here

::: gst-libs/gst/video/gstvideometa.h
@@ +39,3 @@
+#define GST_VIDEO_REGION_OF_INTEREST_META_API_TYPE
(gst_video_region_of_interest_meta_api_get_type())
+#define GST_VIDEO_REGION_OF_INTEREST_META_INFO
(gst_video_region_of_interest_meta_get_info())
+typedef struct _GstVideoRegionOfInterestMeta GstVideoRegionOfInterestMeta;

Remove this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.