[Bug 704070] video: Add Region Of Interest (roi) meta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704070
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249207|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-15 15:04:22 UTC ---
Review of attachment 249207:
 --> (https://bugzilla.gnome.org/review?bug=704070&attachment=249207)

::: gst-libs/gst/video/gstvideometa.c
@@ +532,3 @@
+/* Region of Interest Meta implementation
*******************************************/
+GQuark
+gst_video_region_of_interest_meta_bounding_box_get_quark (void)

Remove this, the idea is that this is *always* the bounding box, and nothing
else. The ROI type would be stuff like "face", "chicken", etc

@@ +658,3 @@
+  return gst_buffer_add_video_region_of_interest_meta_by_quark(\
+    buffer,
+    gst_video_region_of_interest_meta_bounding_box_get_quark(),

g_quark_from_string(roi_type) instead

@@ +666,3 @@
+gst_buffer_add_video_region_of_interest_meta_by_quark (GstBuffer * buffer,
+                               GQuark roi_type, 
+                   gint id, gint parent_id,

I wouldn't expose the ids here

::: gst-libs/gst/video/gstvideometa.h
@@ +263,3 @@
+GQuark             gst_video_region_of_interest_meta_bounding_box_get_quark
(void);
+#define GST_VIDEO_REGION_OF_INTEREST_META_IS_BOUNDING_BOX(type) \
+        ((type) == gst_video_region_of_interest_meta_bounding_box_get_quark())

Remove these bounding box things

@@ +278,3 @@
+                                        guint x, guint y, 
+                                        guint w, guint h);
+GstVideoRegionOfInterestMeta
*gst_buffer_add_video_region_of_interest_meta_by_quark (GstBuffer * buffer, 

meta_from_quark() maybe

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.