[Bug 702380] [basertppayload] Provide a GstBufferPool for output rtp buffers

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jul 15 23:58:10 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=702380
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249238|none                        |accepted-commit_now
             status|                            |

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-16 06:58:03 UTC ---
Review of attachment 249238:
 --> (https://bugzilla.gnome.org/review?bug=702380&attachment=249238)

Looks good to me

::: libs/gst/base/gstadapter.c
@@ +804,3 @@
  * This function is potentially more performant than gst_adapter_take()
  * since it can reuse the memory in pushed buffers by subbuffering
+ * or merging. This function will always return a contiguous buffer.

Maybe "always return a buffer with a single memory region"?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list