[Bug 704340] osvideosink: code refactoring: splitting obj-c code to separate files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704340
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249297|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-17 08:46:32 UTC ---
Review of attachment 249297:
 --> (https://bugzilla.gnome.org/review?bug=704340&attachment=249297)

Basically looks good but:

::: sys/osxvideo/osxvideosink.m
@@ +847,2 @@
   }
   if (osxvideosink->osxwindow != NULL && view != NULL) {

Is it guaranteed here that we always have ->osxwindow? Otherwise you'll lose
the superview setting as you don't store it anywhere else.

@@ +860,2 @@
   if (osxvideosink->osxwindow) {
+    [osxvideosink->osxwindow->gstview addToSuperview:
osxvideosink->osxwindow->superview];

Also this code does not check for osxwindow!=NULL, while the above does

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.