[Bug 704340] osvideosink: code refactoring: splitting obj-c code to separate files

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jul 17 02:41:10 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=704340
  GStreamer | gst-plugins-good | git

--- Comment #15 from Alexey Chernov <4ernov at gmail.com> 2013-07-17 09:41:03 UTC ---
(In reply to comment #10)
> (From update of attachment 249302 [details])
> Not really reviewing this one here, would be great to split it into multiple
> patches. One just moving the code around (and thus not needing a real review)
> and others for the functional changes.

Yes, it's quite big now. The problem is that the splitted part was tightly
connected to main part, so I'm afraid, there can't be a simple patch which just
moves it to separate files. It's possible to reach, but *.m files would use
parts of one another (with 'extern').

Sebastian, could you please suggest how can I split a commit in git, given that
all these patches is committed in my local git repo? Never did this kind of
things so it looks quite complex task for me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list