[Bug 704340] osvideosink: code refactoring: splitting obj-c code to separate files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704340
  GStreamer | gst-plugins-good | git

--- Comment #18 from Alexey Chernov <4ernov at gmail.com> 2013-07-17 11:09:36 UTC ---
(In reply to comment #17)
> (In reply to comment #12)
> > (In reply to comment #7)
> > 1) It is guaranteed, that osxwindow exists in case set_window_handle() was
> > called in states higher than READY. Is it generally expected to be called in
> > any state? If so, that should be changed. Didn't take it into account, sorry.
> 
> Yes

OK. Would it be normal to fix it on top of all these changes? I think, it would
be some minor changes.

> > 2) I think, I don't get it. Do you mean, we should also check for superview
> > here? Or should it be moved to previous branch?
> 
> No I mean that this code is using ->osxwindow unconditionally, while a few
> lines above you check if it's not NULL. So could crash probably.

No, not really. This check: "if (osxvideosink->osxwindow) {" isn't removed so
it should be safe to use ->osxwindow.

> (In reply to comment #15)
> Ok, leave it as is then :) It looks good, but I might've missed something. So
> would prefer to have Andoni look at it too.

Yes, thank you. Let's wait for Andoni's review.

> (In reply to comment #16)
> That's the plan, and it should already work on X11, Wayland, OSX, Windows and
> Android right now. X11, Wayland and Windows will use other, more optimal sinks
> by default though (there's better API then GL available on these platforms).

Very nice. So positive news, hope to try it for OSX. Especially given that
osxvideosink has quite serious problems with GL performance.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.