[Bug 699077] videorate: Add a property to modify clip speed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699077
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249442|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-18 10:16:42 UTC ---
Review of attachment 249442:
 --> (https://bugzilla.gnome.org/review?bug=699077&attachment=249442)

::: tests/check/elements/videorate.c
@@ +1053,3 @@
+
+  /* Next expected timestamp with fps 25/1 */
+  *expected_ts += 40000000;

The timestamps should be scaled by the rate, same goes for the durations. Or am
I missing something here? So they won't actually be +=GST_SECOND/25 but
+=(GST_SECOND/25) / rate? Or is the framerate kept, just the speed increased
(so frames dropped/duplicated)?

@@ +1085,3 @@
+
+  /* Push 0.5sec of buffers, output expected 1sec with rate 0.5  */
+  for (ts = 0; ts < 0.5 * GST_SECOND; ts += GST_SECOND / 33) {

Shouldn't this be GST_SECOND / 25 (i.e. 25fps)?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.