[Bug 694299] crash in put_pixels16_sse2() with SVQ1 video

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=694299
  GStreamer | gst-libav | unspecified

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249501|none                        |needs-work
             status|                            |

--- Comment #31 from Edward Hervey <bilboed at gmail.com> 2013-07-18 14:24:20 UTC ---
Review of attachment 249501:
 --> (https://bugzilla.gnome.org/review?bug=694299&attachment=249501)

Needs work

::: gst-libs/gst/video/video-info.c
@@ +722,3 @@
   gint width, height;
   gint padded_width, padded_height;
+  gint i, j, n_planes;

I can't see where j is used.

@@ +785,3 @@
         (hedge * GST_VIDEO_FORMAT_INFO_PSTRIDE (vinfo, comp));
+
+    offset = (offset + align->stride_align[i]) & ~align->stride_align[i];

you're overwriting offset again. Which one do you want ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.