[Bug 704498] Doesn't compile on W32 against OpenGL

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704498
  GStreamer | gst-plugins-gl | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ystreet00 at gmail.com

--- Comment #1 from Matthew Waters <ystreet00 at gmail.com> 2013-07-19 04:49:04 UTC ---
(In reply to comment #0)
> make[5]: *** [libgstgl_win32_la-gstglwindow_win32.lo] Error 1
> 
> The type GLeglImageOES is from GLES/glext.h and is not present in any of the
> GL/*.h headers. In GLES/glext.h it is defined like this:
> 
> /* GL_OES_EGL_image */
> #ifndef GL_OES_EGL_image
> typedef void* GLeglImageOES;
> #endif
> ...
> /* GL_OES_EGL_image */
> #ifndef GL_OES_EGL_image
> #define GL_OES_EGL_image 1
> ...

This was taken out by 8e92f43e48cdb979c1d9581459552fa8f4723be2.  Should be
replaced.

> 
> A quick-and-dirty way to fix this is to add
> 
> #ifndef GL_OES_EGL_image
> typedef void* GLeglImageOES;
> #endif
> to gstglapi.h (after all GL and/or GLES headers are included)
> 
> The type is used in the prototypes of EGLImageTargetTexture2D and
> EGLImageTargetRenderbufferStorage.
> 
> Considering the fact that they come from gles1gles2.h (that is, functions that
> are only available in GLES, not in GL), it's clearly wrong to even consider
> them when GLES is not available. Why the contents of gles1.h, gles1gles2.h and
> gles2.h aren't under appropriate #ifdef?

Because if we did that, then we would have different struct placement and sizes
for the GstGLFuncs vtable (ABI). And things could blow up big time if we mix
and match libgstgl with libgstopengl with different GL apis enabled.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.