[Bug 703346] Integrate shaders from eglglessink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703346
  GStreamer | gst-plugins-gl | git

--- Comment #7 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-19 07:27:22 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > > Maybe drop the tex_scaling bits everywhere for now until we support arbitrary
> > > > strides. That makes the code simpler
> > > 
> > > And breaks the resulting image for video formats with subsampling.
> > 
> > For the planar formats you'll have different width/height values depending on
> > the subsampling in glTexImage2D(). However in the shader you'll always go from
> > 0.0 to 1.0 in all directions and no scaling is required there (1.0 would be at
> > the end of the texture, i.e. the pixel at 1/4 width for Y41B chroma planes).
> 
> And that will fail with the TEXTURE_RECTANLGE target which we currently use for
> Desktop GL.  TexCoords with TEXTURE_RECTANGLE are unnormalized i.e. go from 0
> to width/height NOT 0 to 1.0.  You may want to instead check for the NPOT
> extension and use that if you want normalized TexCoords.  It could also be
> implemented using multitexturing in the shader i.e. use gl_TexCoord[i].  IMHO
> it's just a different way of doing the same thing and doesn't really matter.

Ah! Sorry for the confusion then, I only really know GLES shaders. It all makes
sense then

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.