[Bug 704507] gstglimagesink: Replace pointer properties with signals
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jul 19 11:34:28 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=704507
GStreamer | gst-plugins-gl | unspecified
--- Comment #7 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2013-07-19 18:34:26 UTC ---
Created an attachment (id=249656)
View: https://bugzilla.gnome.org/attachment.cgi?id=249656
Review: https://bugzilla.gnome.org/review?bug=704507&attachment=249656
Patch to update the recordgraphic example.
I'll do all this but I've got a problem:
To remove the client-draw-callback as well in gstglfilterapp, I think it would
make sense to refactor a little the way the callback is handled.
Currently it's passed along with 15 other arguments to gst_gldisplay_use_fbo,
which in turn passes it to gst_glframebuffer_use, and I'm not sure this is
optimal. On that codepath ther's also an intermediary step which I don't
understand the purpose of, namely stuff all these arguments in a structure just
to unpack them and pass them as arguments in another function, I don't see how
that makes sense. (Actually I think it doesn't :)
So yeah I kind of don't want to go and messup with all this too much before
someone else with more knowledge of the code base comes and does a little
cleanup, and when done I'd like to rebase my history a little, no point in
having two different commits for gstglfilterapp IMHO. I think I'll rename the
commits etc.. during that rebase, except if we decide to switch to using a
signal for now.
the attachment I added allows me to run the only example using this
client-draw-callback.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list