[Bug 704222] gldownload: Support for multi-planar format for GLES

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704222
  GStreamer | gst-plugins-gl | git

--- Comment #2 from Matthew Waters <ystreet00 at gmail.com> 2013-07-21 01:42:48 UTC ---
Review of attachment 249158:
 --> (https://bugzilla.gnome.org/review?bug=704222&attachment=249158)

The reason it crashes is that GL_COLOR_ATTACHMENTi (i != 0) is defined to be 0
in gst-libs/gst/gl/gstgles2.h.  Changing that to the correct value makes it
work properly.  I've been thinking about adding a code generator that generates
the enums, typedefs and function definitions we need.  Recently, Khronos
announced their xml registry and code generator which on first glance looks
like what we would need.  See
https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/readme.pdf.

::: gst-libs/gst/gl/glprototypes/gles3opengl.h
@@ -54,3 @@
-                     (GLsizei n, const GLenum *bufs))
-GST_GL_EXT_END ()
-

This should stay here.  GST_GL_API_GLES3 is correct.  It is the GL api that the
function is core in.  If that fails it should try the NV extension.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.