[Bug 690934] tsdemux: setting program-number has no effect

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690934
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.3

--- Comment #9 from Edward Hervey <bilboed at gmail.com> 2013-07-22 11:47:37 UTC ---
commit dfb101e0edf16733997dd33e4fb43071dc26d7b8
Author: Douglas Bagnall <douglas at paradise.net.nz>
Date:   Sun Mar 10 12:07:40 2013 +1300

    tsdemux: disentangle requested program number from active program number

    The program_number attribute was overloaded, trying to indicate both
    the currently playing program, and the program requested via the
    "program-number" property.  The end result was that setting the
    property didn't work (see #690934).

    I added a new requested_program_number field rather than reviving the
    current_program_number field because it seemed this would result in
    fewer changes overall and be less confusing.  It breaks symmetry with
    the "program-number" property, but it retains parallels with the likes
    of program->program_number.

    Because gst_ts_demux_reset is called after the properties have been
    parsed, requested_program_number is initialised in gst_ts_demux_init.
    Whether this is exactly the right place, I don't know.

commit 8e4f966018409592eca28014bdafaffb4ef59d0a
Author: Jesper Larsen <jesper.larsen at ixonos.com>
Date:   Wed Mar 6 12:15:47 2013 +0100

    tsdemux: fix program-number functionality

    Setting the program-number property does not affect which program
    is actually being demuxed.

    Moving the initialization of the program_number from
    gst_ts_demux_reset to gst_ts_demux_init seems to fix this issue.

    https://bugzilla.gnome.org/show_bug.cgi?id=690934

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.