[Bug 704222] gldownload: Support for multi-planar format for GLES

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704222
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249767|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-23 07:24:56 UTC ---
Review of attachment 249767:
 --> (https://bugzilla.gnome.org/review?bug=704222&attachment=249767)

Well, why would it ever dwelve into the GLES3 API if the API selected was only
GLES2? Or is the only difference then that it doesn't try the non-extension
variants? Maybe that code should be changed to always try the extension and
normal variants?

Anyway:
objdump -T /usr/lib/x86_64-linux-gnu/libGLESv2.so.2  | grep NV
0000000000004900 g    DF .text    0000000000000000  Base        glDrawBuffersNV
0000000000004140 g    DF .text    0000000000000000  Base        glReadBufferNV

::: gst-libs/gst/gl/gstglapi.h
@@ +65,3 @@
   GST_GL_API_OPENGL3 = (1 << 1),
   GST_GL_API_GLES = (1 << 15),
   GST_GL_API_GLES2 = (1 << 16),

Shouldn't GLES2 be subset of GLES then? And OPENGL3 of OPENGL?

@@ +66,3 @@
   GST_GL_API_GLES = (1 << 15),
   GST_GL_API_GLES2 = (1 << 16),
+  GST_GL_API_GLES3 = GST_GL_API_GLES2 + (1 << 17),

Instead of a plus, make it the binary operation it actually is: | :) Makes it
more intuitive IMHO

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.