[Bug 704222] gldownload: Support for multi-planar format for GLES

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704222
  GStreamer | gst-plugins-gl | git

--- Comment #12 from Matthew Waters <ystreet00 at gmail.com> 2013-07-23 07:55:00 UTC ---
(In reply to comment #10)
> Review of attachment 249767 [details]:
> 
> Well, why would it ever dwelve into the GLES3 API if the API selected was only
> GLES2? Or is the only difference then that it doesn't try the non-extension
> variants? Maybe that code should be changed to always try the extension and
> normal variants?

It already tries all extension variants, regardless of GL vs GLES selected. 
And it already tries the non-extension variant if it can't find the function in
the core GL api specified (the GST_GL_API_GLES2 you kept wanting to change).

All of this logic is in gstglfeature.c. It makes more sense to me in code :).

> Anyway:
> objdump -T /usr/lib/x86_64-linux-gnu/libGLESv2.so.2  | grep NV
> 0000000000004900 g    DF .text    0000000000000000  Base        glDrawBuffersNV
> 0000000000004140 g    DF .text    0000000000000000  Base        glReadBufferNV

If you run with GST_DEBUG=default:9 it should show some debug about the
function retrieval. Specifically whether it could find the extension in the
extension list and whether it failed to get a function (and thus the whole
extension).

> ::: gst-libs/gst/gl/gstglapi.h
> @@ +65,3 @@
>    GST_GL_API_OPENGL3 = (1 << 1),
>    GST_GL_API_GLES = (1 << 15),
>    GST_GL_API_GLES2 = (1 << 16),
> 
> Shouldn't GLES2 be subset of GLES then? And OPENGL3 of OPENGL?

No because there were some functions removed in the GLES -> GLES2 transition
and OPENGL3 effectively means GL 3 minus the deprecated bits (fixed function
pipeline).  If you have GL 3 with the compatibility profile, that would be
OPENGL3 | OPENGL.  Yes, the OPENGL and OPENGL3 functions overlap and we will
have to accommodate that when we ask for a GL3 forward compatible context.

> @@ +66,3 @@
>    GST_GL_API_GLES = (1 << 15),
>    GST_GL_API_GLES2 = (1 << 16),
> +  GST_GL_API_GLES3 = GST_GL_API_GLES2 + (1 << 17),
> 
> Instead of a plus, make it the binary operation it actually is: | :) Makes it
> more intuitive IMHO

ok :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.