[Bug 309117] filesink: non-fatal out of disk space handling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=309117
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126735|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-24 08:03:08 UTC ---
Review of attachment 126735:
 --> (https://bugzilla.gnome.org/review?bug=309117&attachment=126735)

::: gstfilesink.c
@@ +45,3 @@
 #include <sys/types.h>
+#include <sys/stat.h> 
+#include <sys/statfs.h>

Need to check for this with configure

@@ +177,3 @@

+  g_object_class_install_property (gobject_class, PROP_RESERVED_SPACE,
+      g_param_spec_uint ("reserved-space", "Reserved Storage Space",

Should be guint64 property

@@ +276,3 @@
       break;
+    case PROP_RESERVED_SPACE:
+      if(G_VALUE_HOLDS_UINT64(value))

That will never happen, just always make this a guint64 property

@@ +599,3 @@
+  /* Each time the reserved check halfs, update and possibly send an error,
the
+   * current buffer was written, so return flow ok. */
+  if(filesink->reserved_space && filesink->next_space_check < 0) {

Conditionally do that if the required API is available... some #ifdef around
here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.