[Bug 693281] [PATCH] GstObject: re-enable "notify::parent"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693281
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235331|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-24 09:26:38 UTC ---
Review of attachment 235331:
 --> (https://bugzilla.gnome.org/review?bug=693281&attachment=235331)

::: gst/gstobject.c
@@ +451,2 @@
   /* now let the parent dispatch those, too */
+  parent = gst_object->parent;

Maybe just special case the "parent" property here? If it's the parent property
and it is for this very specific object, don't take the lock. Otherwise (i.e.
also for the parents of the newly parented object) take the lock.

This should be safe as we know that when the parent is changed the lock is
taken. However emitting a signal while some object lock is taken is not ideal,
it can easily cause deadlocks if the application does something from this
signal.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.