[Bug 691712] [API] codecparsers: add GstMetas to pass parsing results downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691712
  GStreamer | gst-plugins-bad | git

--- Comment #46 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-07-25 04:56:17 UTC ---
Review of attachment 250047:
 --> (https://bugzilla.gnome.org/review?bug=691712&attachment=250047)

::: gst/videoparsers/gstmpegvideoparse.c
@@ +622,3 @@
+    if (slice_index >= mpvparse->slice_info_array->len)
+      mpvparse->slice_info_array = g_array_set_size
(mpvparse->slice_info_array,
+          mpvparse->slice_info_array->len + 1);

I don't think GArray works like a GList whereby you need to re-assign the
output to the variable. :)

Another g_array_set_size() is missing elsewhere when you have completed to
parse all slices to set the final GArray->len to the actual number of slices.
This happens when you have less slices than the estimated amount of slices used
to pre-allocate the array.

Unless I missed a slice_info_array->len assignment elsewhere?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.