[Bug 681368] typefinding: CSV file is detected as MP3

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681368
  GStreamer | gst-plugins-base | 1.0.6

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.3

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-07-25 12:21:36 UTC ---
commit ef5c6d351f04ff5d711912971d77c4be75963800
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Jul 25 11:56:07 2013 +0100

    typefinding: don't detect mp3 based on just a few bits

    Remove dodgy code that detects mp3 with as little as
    a valid frame sync at the beginning. This was only used
    in some unit tests in -good where there were only a few
    bytes after the id3 tag. We now require at least two
    frame headers.

    Fixes mis-dection of text files with UTF-16 LE BOM as mp3.

    https://bugzilla.gnome.org/show_bug.cgi?id=681368



$ gst-typefind-1.0 ~/samples/misc/681368-typefinding-is-not-mp3-*
/home/tpm/samples/misc/681368-typefinding-is-not-mp3-1.csv - text/utf-16,
endianness=(int)1234
/home/tpm/samples/misc/681368-typefinding-is-not-mp3-2.csv - text/utf-16,
endianness=(int)1234

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.