[Bug 704774] appsrc: add "queued-byte" action signal

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704774
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250100|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-25 12:36:45 UTC ---
Review of attachment 250100:
 --> (https://bugzilla.gnome.org/review?bug=704774&attachment=250100)

Don't call gst-indent on headers, and don't change the header at all please

::: gst-libs/gst/app/gstappsrc.c
@@ +385,2 @@
   /**
+   * GstAppSrc::queued-byte:

I'd call it current-bytes instead, similar to what is used in queue for example

@@ -456,3 @@
-    *
-    */
-  gst_app_src_signals[SIGNAL_QUEUED_BYTE] =

Please provide a patch directly against git master, excluding your previous
changes

@@ +1563,1 @@
 gst_app_src_get_queued_bytes (GstAppSrc * appsrc)

This should stay static

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.