[Bug 683010] gst_tag_list_add_value_internal() behaviour for tags with no merge function

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jul 25 13:37:12 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=683010
  GStreamer | gstreamer (core) | git

LRN <lrn1986> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lrn1986 at gmail.com

--- Comment #8 from LRN <lrn1986 at gmail.com> 2013-07-25 20:37:07 UTC ---
That sounds like trying to shoehorn the reality into your idea of what the
reality should be.

I.e. you think that there should only be one instance of tag X, but, say,
Matroska spec doesn't, and an mkv file does have multiple X tags. Or it has A,
B and C, and all three can only be mapped into X in GStreamer, thus X will have
multiple values.

Should extra info be just _dropped_? That is something i don't want to see
happening. My original goal, when i started messing with the Matroska demuxer
and tag code, was to squeeze as much info from a file as possible. Dropping any
info is contrary to that goal.

Again, AFAIU applications that expect to fetch one value from a tag, and do use
the API that fetches only one value from a tag - they will actually fetch one
value from a tag, even if it's a list of values. That's what merge functions
are for.

Only apps that do not follow the spec (i.e. they read tags as they are, and
don't make assumptions about tags having only one or multiple values) will see
the difference.
If you are worried about these apps, you can make an API that enables/disables
the new behaviour, and leave it disabled by default.

Or just commit this into 1.1 or whatever is the next major release, as you do
with any non-backward-compatible change.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list