[Bug 660260] [ismlmux] Add support for GstForceKeyUnit events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660260
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202539|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-26 09:49:13 UTC ---
Review of attachment 202539:
 --> (https://bugzilla.gnome.org/review?bug=660260&attachment=202539)

Generally looks good but:

::: gst/isomp4/gstqtmux.c
@@ +2014,3 @@
+  pad_sync = qtmux->fragment_method != FRAGMENT_METHOD_EVENT && (sync
+      && pad->sync);
+  event_sync = pad->forcekeyunit_event != NULL && pad->sync;

Note that there can be multiple forcekeyunit events (on different pads but also
on the same), and that they can also contain a timestamp when this should
happen. Also you should probably handle upstream forcekeyunit events too here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.