[Bug 704921] matroskademux: memory leak in check_subtitle_buffer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704921
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250187|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-26 09:55:34 UTC ---
Review of attachment 250187:
 --> (https://bugzilla.gnome.org/review?bug=704921&attachment=250187)

::: gst/matroska/matroska-demux.c
@@ +3021,2 @@
       *buf = newbuf;
+      gst_buffer_map (*buf, &map, GST_MAP_READ);

Instead of useless mapping, maybe remember in a "needs_unmap" boolean if you
need to unmap. Also the unmapping should IMHO happen before all the copy_into()
calls above

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.