[Bug 704950] videomixer: add colorspace conversion

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jul 26 12:49:31 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=704950
  GStreamer | gst-plugins-good | git

--- Comment #6 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2013-07-26 19:49:29 UTC ---
(In reply to comment #4)
> This doesn't seem to be the best approach. The biggest issue is the duplication
> of code from videoconvert, which at best creates a maintenance headache. What
> benefits does this provide over using multiple videoconvert elements?

As __tim said, when the code is moved in libgstvideo we'll make use of it, but
that's indeed an issue.

The problem with using multiple videoconvert elements before the sinks is that
first not everyone puts videoconverts before videomixer, and second that would
imply reconfiguring the sinkpads when a new format is requested, and this is
racy by nature as the reconfiguring is asynchronous, meaning you might lose
frames, we discussed it on the irc and decided that this was indeed the best
method.

Another issue was to decide what to return in get_caps in the interval, and
also make sure we wouldn't go in an infinite reconfiguration loop, as was
actually the case until now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list