[Bug 699517] v4l2src delivered buffer from C920 camera to uvch264src corrupt?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699517
  GStreamer | gst-plugins-bad | 1.1.2

--- Comment #2 from Robert Krakora <rob.krakora at messagenetsystems.com> 2013-07-26 20:08:16 UTC ---
Created an attachment (id=250238)
 View: https://bugzilla.gnome.org/attachment.cgi?id=250238
 Review: https://bugzilla.gnome.org/review?bug=699517&attachment=250238

Patch to add back "always-copy=true" default functionality for v4l2src

The previously attached patch works to fix the corruption and memory leak
caused by uvch264src.  However, in version 0.10 v4l2src, which is utilized by
uvch264src, defaulted to always allocating buffers to copy data from buffers in
it's buffer pool for consumption by downstream plugins.  This default behaviour
has been removed for 1.xx.  I "hacked" "always-copy=true" back in by setting
the "copy_threshold" to "num_buffers+1" to insure the buffer pool buffers are
always copied to newly allocated buffers for consumption by downstream plugins.
 I can run indefinitely with C920 camera with uvch264src with this modification
as well as the previous patch.  By default, uvch264_src in version 0.10 always
ran with v4l2src with "always-copy=true" since that was the default.

Test stream:

gst-launch-1.0 uvch264src device=/dev/video0 name=src auto-start=true src.vfsrc
! queue ! fakesink src.vidsrc ! queue ! video/x-h264 ! fakesink

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.