[Bug 699517] v4l2src delivered buffer from C920 camera to uvch264src corrupt?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699517
  GStreamer | gst-plugins-bad | 1.1.2

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250238|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-07-28 07:37:42 UTC ---
Review of attachment 250238:
 --> (https://bugzilla.gnome.org/review?bug=699517&attachment=250238)

::: gst-plugins-good-1.1.2/sys/v4l2/gstv4l2bufferpool.c
@@ +416,3 @@
         /* we are certain that we have enough buffers so we don't need to
          * copy */
+        copy_threshold = num_buffers + 1;

The comment no longer match the code, and we are doing if for no reason, not
sure if this is the right fix though, but to be correct these would need to be
fixed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.