[Bug 705090] Bink playback doesn't work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705090
  GStreamer | gst-libav | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250391|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-07-30 07:47:55 UTC ---
Review of attachment 250391:
 --> (https://bugzilla.gnome.org/review?bug=705090&attachment=250391)

So this is a container format, video codec and audio codec? Each of them should
get different caps

::: gst-libav-1.0.6/ext/libav/gstavcodecmap.c
@@ +923,3 @@
+    case CODEC_ID_BINKVIDEO:
+      caps =
+          gst_ff_vid_caps_new (context, codec_id, encode, "video/binkvideo",

Should be video/x-bink

@@ +924,3 @@
+      caps =
+          gst_ff_vid_caps_new (context, codec_id, encode, "video/binkvideo",
+            "format", G_TYPE_STRING, "I420", NULL);

Is the format really relevant here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.