[Bug 701421] opencv: add foreground/background segmentation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701421
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245821|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-04 16:04:56 UTC ---
Review of attachment 245821:
 --> (https://bugzilla.gnome.org/review?bug=701421&attachment=245821)

::: ext/opencv/gstsegmentation.c
@@ +195,3 @@
+  g_object_class_install_property (gobject_class, PROP_DISPLAY,
+      g_param_spec_boolean ("display", "Display",
+          "Display the foreground as white over background black ",

Maybe call that property black-white instead? display sounds like it
enables/disables displaying of the effect

@@ +298,3 @@
+  /* Codebook method */
+  segmentation->TcodeBook = (codeBook *)
+      g_malloc (sizeof (codeBook) *

This must be released with release_all_images() too, otherwise you leak it

@@ +401,3 @@
+  }
+  /* Create the foreground and background masks using BackgroundSubtractorMOG
[1], 
+   *  Gaussian Mixture-based Background/Foreground segmentation slgorithm.
OpenCV 

Typo slgorithm

@@ +461,3 @@
+
+
+#ifdef CODE_FROM_OREILLY_BOOK

Why? :)

::: ext/opencv/opencv_wrapper.h
@@ +1,1 @@
+/*

You could also just put your element into a .cpp file instead of having this
wrapper :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.