[Bug 701706] gst-omx testegl.c example not compatible with gstreamer 1.x

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jun 7 03:18:55 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701706
  GStreamer | gst-omx | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246227|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-07 10:18:52 UTC ---
Review of attachment 246227:
 --> (https://bugzilla.gnome.org/review?bug=701706&attachment=246227)

Just one minor comment, and you should squash that together with the
Makefile.am patch and only keep the new mode as a separate patch. otherwise
looks good

::: examples/egl/testegl.c
@@ +4,3 @@
 Copyright (C) 2013, Fluendo S.A.
    @author: Josep Torra <josep at fluendo.com>
+   @author: Ilya Smelykh <ilya at videoexpertsgroup.com>

You might want to add a new Copyright line here as I assume you're not working
for Fluendo ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list