[Bug 701421] opencv: add foreground/background segmentation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701421
  GStreamer | gst-plugins-bad | 1.x

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-10 11:52:58 UTC ---
Review of attachment 246359:
 --> (https://bugzilla.gnome.org/review?bug=701421&attachment=246359)

::: ext/opencv/gstsegmentation.cpp
@@ +135,3 @@
+      {0, NULL, NULL},
+    };
+    etype = g_enum_register_static ("GstSegmentationMethod", values);

The type name should probably contain the element name, otherwise there is risk
of conflict

@@ +350,3 @@
+gst_segmentation_release_all_pointers (GstSegmentation * filter)
+{
+  cvReleaseImage (&filter->cvRGBA);

You should set at least this one here to NULL, otherwise there's risk for
double free. Or is cvReleaseImage() doing that already?

@@ +363,3 @@
+
+static GstFlowReturn
+gst_segmentation_transform_ip (GstBaseTransform * btrans, GstBuffer * buf)

Note that GstVideoFilter has its own vfunc for this:
  GstFlowReturn (*transform_frame)    (GstVideoFilter *filter,
                                       GstVideoFrame *inframe, GstVideoFrame
*outframe);
  GstFlowReturn (*transform_frame_ip) (GstVideoFilter *trans, GstVideoFrame
*frame);

You might want to use that, or use GstOpenCVVideoFilter

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.