[Bug 701421] opencv: add foreground/background segmentation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701421
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246400|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-11 11:44:57 UTC ---
Review of attachment 246400:
 --> (https://bugzilla.gnome.org/review?bug=701421&attachment=246400)

::: ext/opencv/gstsegmentation.cpp
@@ +295,3 @@
+static gboolean
+//gst_segmentation_set_caps (GstBaseTransform * btrans, GstCaps * incaps,
+//    GstCaps * outcaps)

Don't use C99/C++ comments, also can just go away, no?

@@ +303,3 @@
+  GstVideoInfo info;
+  CvSize size;
+  gst_video_info_from_caps (&info, incaps);

You already get the info passed as parameter

@@ +375,3 @@
+
+  /*  get image data from the input, which is RGBA */
+  filter->cvRGBA->imageData = (char *) GST_VIDEO_FRAME_COMP_DATA (frame, 0);

You might want to do something to handle the different possible strides here
too... if OpenCV supports that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.