[Bug 701404] dashdemux: should not buffer the entire Period

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 12 08:03:53 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701404
  GStreamer | gst-plugins-bad | 1.x

--- Comment #5 from Greg Rutz <greg at gsr-tek.com> 2013-06-12 15:03:51 UTC ---
(In reply to comment #4)
> Review of attachment 245806 [details]:
> 
> ::: ext/dash/gstdashdemux.c
> @@ +1571,3 @@
> +
> +  /* Prevent this thread from constantly running */
> +  g_usleep (500000);
> 
> This is definitely wrong, you probably want to use a gst_clock_id_wait() until
> the timeout expires, but be ready to be cancelled before in case of flush or of
> the element being stopped.

Understood.  I think I will propose a totally different fix as part of a bug. 
I would like to stop using GstTask for the download_loop and just use a thread
and a gst_clock_wait_id ().  

A new patch is incoming that has the sleep removed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list